Support IPv6 in address assignment and gateway #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several clues: 1. Interface address and gateway should be received from e.g. slirp4netns. There is already a comment on it in code. Need to fix slirp4netns and others. 2. Setting static IPv6 address fd00::1 to tap0 looks weired, since e.g. slirp4netns already could give dynamic address from fd00::/64 network, but there is a race. Rootlesskit can't set default route via fd00::2 unless IPv6 address and route from fd00::/64 is set to tap0 Signed-off-by: Alexey Perevalov <[email protected]>
AlexeyPerevalov
force-pushed
the
ipv6_support
branch
from
fce79b4 to
58b2c6c
Compare
AkihiroSuda
reviewed
Apr 12, 2025
| ) | ||
|
|
||
| func PrepareTap(childPID int, childNetNsPath string, tap string) error { | ||
| logrus.Debugf("PrepareTap") |
There was a problem hiding this comment.
This debug message doesn't seem meaningful?
There was a problem hiding this comment.
Oh, yes. I'll remove this debug leftover.
|
Can we have a test? |
yes, I'll add test. Did you mean these tests in hack/* |
Yes, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rootlesskit assigns ipv4 address and routes for ipv4, but not for ipv6, this PR address IPv6 issue.
Some tools like slirp4netns could assign ip address, routes, but rootlesskit doesn't request them to do it.
Couple clues: