Feature/gradient layer accessors #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glm4
requested review from
germanStabile,
pMalvasio,
CamilaMoscatelli and
mato2593
germanStabile
approved these changes
Jul 16, 2020
| let randomChange = arc4random_uniform(4) | ||
| switch randomChange { | ||
| case 0: | ||
| self.gradientLayer.uiColors = [UIColor.random, UIColor.random] |
| var degrees = CGFloat(atan2(product, determinant)) * 180 / CGFloat.pi | ||
| if degrees < 0 { degrees = 360 + degrees } | ||
|
|
||
| return degrees.truncatingRemainder(dividingBy: 360) |
There was a problem hiding this comment.
maybe add radToDegrees and degreesToRad helpers?
mato2593
approved these changes
Jul 27, 2020
Comment on lines
+107
to
128
| switch ang { | ||
| case 0...45, 315...360: | ||
| return isStartPoint ? | ||
| CGPoint(x: 0, y: n * tanx(ang) + n) : | ||
| CGPoint(x: 1, y: n * tanx(-ang) + n) | ||
| case 45...135: | ||
| return isStartPoint ? | ||
| CGPoint(x: n * tanx(ang - 90) + n, y: 1) : | ||
| CGPoint(x: n * tanx(-ang - 90) + n, y: 0) | ||
| case 135...225: | ||
| return isStartPoint ? | ||
| CGPoint(x: 1, y: n * tanx(-ang) + n) : | ||
| CGPoint(x: 0, y: n * tanx(ang) + n) | ||
| case 225...315: | ||
| return isStartPoint ? | ||
| CGPoint(x: n * tanx(-ang - 90) + n, y: 0) : | ||
| CGPoint(x: n * tanx(ang - 90) + n, y: 1) | ||
| default: | ||
| return isStartPoint ? | ||
| CGPoint(x: 0, y: n) : | ||
| CGPoint(x: 1, y: n) | ||
| } |
There was a problem hiding this comment.
I will post the source fro you :)
pMalvasio
approved these changes
Jul 27, 2020
CamilaMoscatelli
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradient attributes accessors