Nenuial/issue76 #77
Open
Nenuial/issue76 #77
+103
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nenuial Thanks for this. I should be able to try it tomorrow. |
|
Great, thanks for your feedback! |
|
I can confirm: this works for me! |
maelle
reviewed
Sep 19, 2024
| freeze_dirs, fixed = TRUE | ||
| ) | ||
|
|
||
| fs::dir_copy(freeze_lang, fs::path(freeze_temp, freeze_dirs)) |
There was a problem hiding this comment.
should all of this go into a well-named helper function?
There was a problem hiding this comment.
I'm not sure I follow. You're suggesting a helper function for the copy and move/delete part, or the entire logic around freeze folders (L205-L224)?
Nenuial
force-pushed
the
Nenuial/issue76
branch
from
e4275cf
to
483931f
Compare
Nenuial
force-pushed
the
Nenuial/issue76
branch
from
483931f
to
3f4621f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adresses the problems mentioned by @joelnitta in #76.
If a freeze folder is present, we should make sure that for each language the frozen content is for that language only.
This should fix #76, but ideally @joelnitta could confirm it before we merge.