Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #78

Merged
merged 29 commits into from
Sep 27, 2024
Merged

Documentation #78

merged 29 commits into from
Sep 27, 2024

Conversation

Nenuial
Copy link
Collaborator

@Nenuial Nenuial commented Sep 18, 2024

This is my attempt at reorganising the documentation.

I tried reorganising everything that was present in the README into different vignettes. I hope it makes sense, otherwise don't hesitate to say so!

This PR should close #46, close #57, close #66 and close #67.

@Nenuial Nenuial requested a review from maelle September 18, 2024 20:41
@Nenuial Nenuial force-pushed the documentation branch 3 times, most recently from ffdc5b5 to 4ed1da5 Compare September 19, 2024 05:56
@Nenuial
Copy link
Collaborator Author

Nenuial commented Sep 19, 2024

@maelle Any ideas how to fix the Windows R-CMD-check? It looks to me as if the babelquarto package isn't available when he tries to build the vignettes 🤯.

Copy link
Contributor

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!!

README.md Show resolved Hide resolved
vignettes/babelquarto.qmd Outdated Show resolved Hide resolved
vignettes/babelquarto.qmd Outdated Show resolved Hide resolved
vignettes/babelquarto.qmd Outdated Show resolved Hide resolved
vignettes/babelquarto.qmd Outdated Show resolved Hide resolved
vignettes/convert.qmd Show resolved Hide resolved
vignettes/convert.qmd Outdated Show resolved Hide resolved
vignettes/convert.qmd Show resolved Hide resolved
vignettes/render-with-ci.qmd Outdated Show resolved Hide resolved
vignettes/render-with-ci.qmd Outdated Show resolved Hide resolved
@Nenuial Nenuial force-pushed the documentation branch 3 times, most recently from ff711bb to 6fe3ee3 Compare September 19, 2024 17:22
@Nenuial
Copy link
Collaborator Author

Nenuial commented Sep 19, 2024

I got the CI fixed in 6fe3ee3 by installing the package locally first.
But this is probably a bit unorthodox, and I can revert these changes if this is a bad idea. I wanted to check if it works.

@Nenuial
Copy link
Collaborator Author

Nenuial commented Sep 20, 2024

I got the CI fixed in 6fe3ee3 by installing the package locally first. But this is probably a bit unorthodox, and I can revert these changes if this is a bad idea. I wanted to check if it works.

I've opened an issue to track this going forward #79.

Copy link
Contributor

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

.lintr Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
vignettes/babelquarto.qmd Outdated Show resolved Hide resolved
vignettes/configuration.qmd Outdated Show resolved Hide resolved
vignettes/convert.qmd Show resolved Hide resolved
vignettes/custom-templates.qmd Outdated Show resolved Hide resolved
vignettes/custom-templates.qmd Outdated Show resolved Hide resolved
vignettes/render-with-ci.qmd Outdated Show resolved Hide resolved
Copy link
Contributor

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such awesome work 👏 🙏

_pkdown.yml Show resolved Hide resolved
vignettes/render-with-ci.qmd Outdated Show resolved Hide resolved
@Nenuial Nenuial merged commit 40de30f into main Sep 27, 2024
6 checks passed
@Nenuial Nenuial deleted the documentation branch September 27, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants