-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #78
base: main
Are you sure you want to change the base?
Documentation #78
Conversation
fb87778
to
6fdbdaf
Compare
cde4340
to
ffdc5b5
Compare
ffdc5b5
to
4ed1da5
Compare
@maelle Any ideas how to fix the Windows R-CMD-check? It looks to me as if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!!
``` | ||
|
||
This is how the config file now looks like: | ||
## Getting Started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the README should feature a few more lines, maybe saying using babelquarto means registering languages once per project/language and then using babelquarto dedicated function to render the book locally or on CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and maybe also links to examples. Basically more of a showcase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the Getting started part a bit more detailed.
For the links, do you have any ideas? The ropensci devguide obviously. But any other projects you are aware of that we could mention?
|
||
This will create a new branch called `gh-pages` in your repository. **Note: as your project was rendered using `quarto render` it won't be multilingual yet.** | ||
|
||
You can then setup your GitHub Actions. In your repository in `.github/workflows/` create a file named `publish.yml` with the following content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really want to maintain this workflow example? Could we instead explain what file to take as starting point then what steps to add? With a link to an example on GitHub from a "real" multilingual project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an excellent question. I started with #57 and it did absolutely not work for me.
I feel that it would be nice to have a complete example of how to deploy a multilingual babelquarto project on GH Pages. But I can understand your argument that this configuration can easily not work for somebody project depending on what they do in their book or website...
I'll give it some more thoughts.
615f8e4
to
ff711bb
Compare
ff711bb
to
6fe3ee3
Compare
I got the CI fixed in 6fe3ee3 by installing the package locally first. |
This is my attempt at reorganising the documentation.
I tried reorganising everything that was present in the README into different vignettes. I hope it makes sense, otherwise don't hesitate to say so!
This PR should close #46, close #57, close #66 and close #67.