Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #78

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Documentation #78

wants to merge 18 commits into from

Conversation

Nenuial
Copy link
Collaborator

@Nenuial Nenuial commented Sep 18, 2024

This is my attempt at reorganising the documentation.

I tried reorganising everything that was present in the README into different vignettes. I hope it makes sense, otherwise don't hesitate to say so!

This PR should close #46, close #57, close #66 and close #67.

@Nenuial Nenuial requested a review from maelle September 18, 2024 20:41
@Nenuial
Copy link
Collaborator Author

Nenuial commented Sep 19, 2024

@maelle Any ideas how to fix the Windows R-CMD-check? It looks to me as if the babelquarto package isn't available when he tries to build the vignettes 🤯.

Copy link
Contributor

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!!

```

This is how the config file now looks like:
## Getting Started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the README should feature a few more lines, maybe saying using babelquarto means registering languages once per project/language and then using babelquarto dedicated function to render the book locally or on CI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and maybe also links to examples. Basically more of a showcase.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the Getting started part a bit more detailed.

For the links, do you have any ideas? The ropensci devguide obviously. But any other projects you are aware of that we could mention?

vignettes/babelquarto.qmd Outdated Show resolved Hide resolved
vignettes/babelquarto.qmd Outdated Show resolved Hide resolved
vignettes/babelquarto.qmd Outdated Show resolved Hide resolved
vignettes/babelquarto.qmd Outdated Show resolved Hide resolved
vignettes/convert.qmd Show resolved Hide resolved
vignettes/convert.qmd Outdated Show resolved Hide resolved
vignettes/convert.qmd Show resolved Hide resolved
vignettes/render-with-ci.qmd Outdated Show resolved Hide resolved

This will create a new branch called `gh-pages` in your repository. **Note: as your project was rendered using `quarto render` it won't be multilingual yet.**

You can then setup your GitHub Actions. In your repository in `.github/workflows/` create a file named `publish.yml` with the following content.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really want to maintain this workflow example? Could we instead explain what file to take as starting point then what steps to add? With a link to an example on GitHub from a "real" multilingual project.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an excellent question. I started with #57 and it did absolutely not work for me.

I feel that it would be nice to have a complete example of how to deploy a multilingual babelquarto project on GH Pages. But I can understand your argument that this configuration can easily not work for somebody project depending on what they do in their book or website...

I'll give it some more thoughts.

@Nenuial Nenuial force-pushed the documentation branch 2 times, most recently from 615f8e4 to ff711bb Compare September 19, 2024 17:19
@Nenuial
Copy link
Collaborator Author

Nenuial commented Sep 19, 2024

I got the CI fixed in 6fe3ee3 by installing the package locally first.
But this is probably a bit unorthodox, and I can revert these changes if this is a bad idea. I wanted to check if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants