Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporarily hard-code R4.3.3 for #45 #47

Merged
merged 1 commit into from
May 14, 2024
Merged

temporarily hard-code R4.3.3 for #45 #47

merged 1 commit into from
May 14, 2024

Conversation

mpadge
Copy link
Member

@mpadge mpadge commented May 14, 2024 •
edited
Loading

@assignUser I think this should fix #45. What do you think? We can then easily remove this line once the GH runner specs get updated.

@mpadge mpadge requested a review from assignUser May 14, 2024 10:25
@mpadge
Copy link
Member Author

mpadge commented May 14, 2024

@assignUser The recent check failures were because of goodpractice in pkgcheck, which has now been fixed. This PR doesn't affect our checks here, because no dep in pkgcheck or here pulls in the Matrix package, but it will resolve issues for anybody else who does need that package in their pkgcheck runs.

assignUser
assignUser approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@assignUser assignUser merged commit f37aa70 into main May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with R update to 4.4
2 participants
@mpadge @assignUser