Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goodpractice archived on CRAN #198

Closed
mpadge opened this issue Apr 30, 2024 · 2 comments
Closed

goodpractice archived on CRAN #198

mpadge opened this issue Apr 30, 2024 · 2 comments

Comments

@mpadge
Copy link
Member

mpadge commented Apr 30, 2024 •
edited
Loading

Thanks to @jromanowska via ropensci/software-review#637 (comment). See also #20, which describes what has to be done. goodpractice issue is ropensci-review-tools/goodpractice#163
@assignUser
Copy link
Collaborator

Hm, again? :/

@mpadge mpadge closed this as completed in 24128bc May 14, 2024
@mpadge
Copy link
Member Author

mpadge commented May 14, 2024

@assignUser Interestingly, the Docker build wasn't yet failing, because r2u still indexed and successfully installed the CRAN version of goodpractice. The above commit just switches to a GitHub install, which will continue to work no matter what.

mpadge added a commit that referenced this issue May 14, 2024
@mpadge
github install goodpractice in all workflows for #198
bdb3e29
mpadge added a commit that referenced this issue May 14, 2024
@mpadge
install goodpractice as remotes via DESC not workflows for #198
f8da782
mpadge added a commit that referenced this issue May 14, 2024
@mpadge
separate gh install of goodpractice for #198
eb557cc 
To allow debugging potential failures of standard r install vs github r install
@mpadge mpadge mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpadge @assignUser