Skip to content

First review for translation of: Softwarereview_intro.pt.Rmd #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

beatrizmilz
Copy link
Contributor

@beatrizmilz beatrizmilz commented Nov 18, 2024

mpadge and others added 26 commits February 14, 2024 15:16
oh dear, sorry about that

Co-authored-by: Maëlle Salmon <[email protected]>
* Add the submit response step

In the author's response step there is no indication about submitting the comment to the bot

* add Spanish

* Update softwarereview_author.es.Rmd

Co-authored-by: Joan Maspons <[email protected]>

---------

Co-authored-by: Maëlle Salmon <[email protected]>
* Removing twitter mention

* Removing twitter from Spanish version
…i#781)

* Add PT-BR automatic translation maintenance_marketing.pt.Rmd

* fix alias

* fix yaml

* Review for Portuguese translation of `maintenance_marketing.pt.Rmd` (ropensci#798)

---------

Co-authored-by: Pedro Faria <[email protected]>
Co-authored-by: Yanina Bellini Saibene <[email protected]>
* add translation

* Review for Portuguese translation of `reviewtempate.Rmd` (ropensci#802)

* Add translated version of template

* Update templates/review.pt.md

Co-authored-by: Rafael Fontenelle <[email protected]>

* Update templates/review.pt.md

Co-authored-by: Rafael Fontenelle <[email protected]>

* Update templates/review.pt.md

---------

Co-authored-by: Rafael Fontenelle <[email protected]>

---------

Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Pedro Faria <[email protected]>
Co-authored-by: Rafael Fontenelle <[email protected]>
* automatic translation

* Review for Portuguese translation of `newstemplate.Rmd` (ropensci#801)

---------

Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Pedro Faria <[email protected]>
@beatrizmilz beatrizmilz changed the title Softwarereview_intro.pt.Rmd-pt-auto-review First review for translation of: Softwarereview_intro.pt.Rmd Nov 18, 2024
@beatrizmilz beatrizmilz changed the base branch from main to softwarereview_intro.pt.Rmd-pt-auto November 18, 2024 14:45
yabellini and others added 2 commits November 18, 2024 11:49
* add translation

* Review for Portuguese translation of `reviewrequesttemplate.Rmd` (ropensci#803)

* Add review

* Add review

* Update templates/request.pt.md

Co-authored-by: Rafael Fontenelle <[email protected]>

* Update templates/request.pt.md

Co-authored-by: Rafael Fontenelle <[email protected]>

* Update templates/request.pt.md

Co-authored-by: Rafael Fontenelle <[email protected]>

* Update templates/request.pt.md

Co-authored-by: Rafael Fontenelle <[email protected]>

---------

Co-authored-by: Rafael Fontenelle <[email protected]>

---------

Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Pedro Faria <[email protected]>
Co-authored-by: Rafael Fontenelle <[email protected]>
maelle and others added 8 commits April 7, 2025 14:36
* improve reviewing guide

* Update softwarereview_reviewer.Rmd

Co-authored-by: mark padgham <[email protected]>

* Update softwarereview_reviewer.Rmd

Co-authored-by: mark padgham <[email protected]>

* news item

* es translation

* pt translation

* Update softwarereview_reviewer.es.Rmd

Co-authored-by: Yanina Bellini Saibene <[email protected]>

* Apply suggestions from code review

Co-authored-by: Yanina Bellini Saibene <[email protected]>

* Update softwarereview_reviewer.pt.Rmd

---------

Co-authored-by: mark padgham <[email protected]>
Co-authored-by: Yanina Bellini Saibene <[email protected]>
 (ropensci#895)

* add link to pkgcheck env vignette to close ropensci#589

* add br.pt translation for testenv update for ropensci#589

* Apply suggestions from code review

Co-authored-by: Francesca Palmeira <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Francesca Palmeira <[email protected]>
Co-authored-by: Yanina Bellini Saibene <[email protected]>
* Add PT-BR automatic translation pkg_security.pt.Rmd

* Apply suggestions from code review

Co-authored-by: Ariana <[email protected]>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Francesca Palmeira <[email protected]>

---------

Co-authored-by: Ariana <[email protected]>
Co-authored-by: Francesca Palmeira <[email protected]>
@beatrizmilz
Copy link
Contributor Author

There are some things that I'm noticing but I don't want to change the text, so I'll leave it as a comment here so it is easier for us to detect and discuss. Ok?


Você pode reconhecer os pacotes do rOpenSci que foram revisados por pares por meio de um emblema verde "peer-reviewed" em seu README, com links para suas revisões (cf [este exemplo](https://github.com/ropensci/restez#locally-query-genbank-)); e por meio de um ícone de comentário azul próximo à sua descrição em [página de pacotes do rOpenSci](https://ropensci.org/packages/) com links para as revisões.
Você pode reconhecer os pacotes da rOpenSci que foram revisados por pares por meio de um selo (*badge*) verde com o texto "peer-reviewed" em seu README, com links para suas revisões ([por exemplo](https://github.com/ropensci/restez#locally-query-genbank-)); e por meio de um ícone de comentário azul próximo à sua descrição na [página de pacotes da rOpenSci](https://ropensci.org/packages/) com links para as revisões.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was quite difficult to understand what it meant in the translation.
I looked up on the website and this is an attempt to describe it a bit better.
But this is a change from the source book, I'm not sure how to proceed.

Suggested change
Você pode reconhecer os pacotes da rOpenSci que foram revisados por pares por meio de um selo (*badge*) verde com o texto "peer-reviewed" em seu README, com links para suas revisões ([por exemplo](https://github.com/ropensci/restez#locally-query-genbank-)); e por meio de um ícone de comentário azul próximo à sua descrição na [página de pacotes da rOpenSci](https://ropensci.org/packages/) com links para as revisões.
Você pode reconhecer os pacotes da rOpenSci que foram revisados por pares por meio de um selo (*badge*) verde com o texto "peer-reviewed" em seu README, com links para suas revisões ([por exemplo](https://github.com/ropensci/restez#locally-query-genbank-)); e por meio de um botão azul com o texto *"Peer-reviewed"* próximo à sua descrição na [página de pacotes da rOpenSci](https://ropensci.org/packages/) com links para as revisões.

@@ -44,20 +44,20 @@ Além disso, os autores e revisores podem entrar em contato com os editores em p

- O LEIAME do seu pacote apresentará um selo de revisão por pares com um link para o tópico de revisão do software.
- Seu pacote receberá um selo [`docs.ropensci.org` site de documentos](#rodocsci) que você pode vincular a partir da DESCRIÇÃO.
- O repositório do seu pacote será transferido para a organização rOpenSci.
- Se você quiser, o repositório do seu pacote poderá ser transferido para a organização rOpenSci.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making more clear what we mean by transfering to rOpenSci org.
But this is not in the English version, check how to proceed.

Suggested change
- Se você quiser, o repositório do seu pacote poderá ser transferido para a organização rOpenSci.
- Se você quiser, o repositório do seu pacote poderá ser transferido para a organização rOpenSci no GitHub.

- O README do seu pacote apresentará um selo de revisão por pares com um link para o tópico de revisão do software.
- Seu pacote terá um [site de documentação em `docs.ropensci.org`](#rodocsci) que você pode referenciar no DESCRIPTION.
- Se você quiser, o repositório do seu pacote poderá ser transferido para a organização rOpenSci.
- Se os(as) revisores(as) [concordarem em ser listados(as) no DESCRIPTION](#authorship), seus metadados mencionarão a revisão.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase is not 100% clear to me.
In "their metadata will mention the review.", "their metadata" is referring to the package metadata?
If so, we can make if more explicit:

Suggested change
- Se os(as) revisores(as) [concordarem em ser listados(as) no DESCRIPTION](#authorship), seus metadados mencionarão a revisão.
- Se os(as) revisores(as) [concordarem em ser listados(as) no DESCRIPTION](#authorship), os metadados do pacote mencionarão a revisão.

@beatrizmilz beatrizmilz marked this pull request as ready for review April 18, 2025 19:57
@beatrizmilz
Copy link
Contributor Author

beatrizmilz commented Apr 18, 2025

Hi! I have finished the first review of this chapter.

I have based the review of the translation for this document: https://raw.githubusercontent.com/ropensci/dev_guide/refs/heads/main/softwarereview_intro.Rmd - there are some things that were diferent (probably because this branch was from some months ago) and I have used that file to check if anything needed to be updated.

I have left some comments in the translation so we can discuss.

I made the mistake of updating the branch to the source code, and now it shows with a lot of differences. But the only file that I have changed is softwarereview_intro.pt.Rmd. I'm not sure what is the best practise in this case: maybe @yabellini can update this branch ropensci:softwarereview_intro.pt.Rmd-pt-auto? Or do I create a new PR with only this file changed? Do I send in this PR #822 ? Or another idea?

@fblpalmeira is doing the second review, right?

@beatrizmilz beatrizmilz moved this to Todo - Automatic Translation in Tradução Português- Guia do programador Apr 18, 2025
@beatrizmilz beatrizmilz moved this from Todo - Automatic Translation to Todo - First Review in Tradução Português- Guia do programador Apr 18, 2025
@beatrizmilz beatrizmilz moved this from Todo - First Review to Todo - Second Review in Tradução Português- Guia do programador Apr 18, 2025
@yabellini
Copy link
Member

@beatrizmilz I updated the other branch, but it looks like this does not solve the problem (and even adds some conflicts).

To have a cleaner PR, can you create a new one that only has the changes to the file softwarereview_intro.pt.Rmd ?

Thank you!

@beatrizmilz
Copy link
Contributor Author

@beatrizmilz I updated the other branch, but it looks like this does not solve the problem (and even adds some conflicts).

To have a cleaner PR, can you create a new one that only has the changes to the file softwarereview_intro.pt.Rmd ?

Thank you!

Hi Yani!
Thank you for the response. I have moved all the comments and suggestions to this existing PR: #822

Let me know if this works!

@yabellini
Copy link
Member

@beatrizmilz Thank you! Yes it works! I will close this one now.

@yabellini yabellini closed this Apr 19, 2025
@yabellini yabellini moved this from Todo - Second Review to Merged in Tradução Português- Guia do programador Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

8 participants