Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gigs 0.4.1.9001 #32

Merged
merged 112 commits into from
Nov 9, 2024
Merged

gigs 0.4.1.9001 #32

merged 112 commits into from
Nov 9, 2024

Conversation

simpar1471
Copy link
Member

See NEWS.md for a full breakdown.

Essentially, this PR includes the last 6 months of breaking changes to the package. It's only not getting a major release at this point because the package is still under review at rOpenSci.

simpar1471 and others added 30 commits March 18, 2024 14:59
…tring for `acronym`. Also speed improvements (to be doc'd later)
…ure for input checking (added `rlang` to Imports)
…_*()`/`compute_*()`/`categorise_*()`

 docs: Update README.Rmd to reflect changes to package

 BREAKING CHANGE: `classify_*()` functions are data-masking now
…internal' functions, like the conversion functions
… `test-growth_(compute/classify).R`. Added test files for `growth_compute.R` and `growth_classify.R`
…e right size-for-GA classes in the right columns
… `life6mo`, which matches the example given in the SJ manuscript
…e with some fixes --> checks errors, warnings, and more
…ions and replaced with `value2zscore()`, `zscore2value()`, `zscore2value()`, and `centile2value()`.

Also performed edits to input-checking functionality, so error/warning messages are formatted better and more consistently.
…`gigs_zcoring_lgls()` now issue helpful warnings based on the supplied data; information on these warnings is in the docs.
… article, there's now data on more packages recommended by @stefvanbuuren during ISGA 2024.
@simpar1471 simpar1471 added the enhancement New feature or request label Nov 9, 2024
@simpar1471 simpar1471 self-assigned this Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 97.07692% with 38 lines in your changes missing coverage. Please review.

Project coverage is 97.48%. Comparing base (f8e85c0) to head (993c542).

Files with missing lines Patch % Lines
R/gigs_zscoring.R 88.60% 27 Missing ⚠️
R/conversion.R 90.47% 10 Missing ⚠️
R/check_params.R 99.31% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master      #32      +/-   ##
===========================================
- Coverage   100.00%   97.48%   -2.52%     
===========================================
  Files           12       15       +3     
  Lines         2000     1549     -451     
===========================================
- Hits          2000     1510     -490     
- Misses           0       39      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simpar1471 simpar1471 merged commit 13b5df5 into master Nov 9, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant