Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on mac M1 #60

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Run tests on mac M1 #60

merged 6 commits into from
Mar 21, 2024

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Mar 18, 2024

Trying to reproduce and fix test failures from CRAN: https://www.stats.ox.ac.uk/pub/bdr/M1mac/lightr.out

@Bisaloo
Copy link
Member Author

Bisaloo commented Mar 21, 2024

The test failures can't be reproduced locally, on GitHub Actions with M1 platform, or on CRAN macbuilder service. Since we are confident parsing works on M1 macs, the solution is to run these checks only on GitHub.

@Bisaloo Bisaloo merged commit e972936 into main Mar 21, 2024
15 checks passed
@Bisaloo Bisaloo deleted the m1-hash-tests branch March 21, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant