-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove sensitive data from vcr #139
base: main
Are you sure you want to change the base?
feat: Remove sensitive data from vcr #139
Conversation
Are the changes in |
Yes. They make sure that |
I don't see how these added lines accomplish that? rebird/tests/testthat/test-ebirdgeo.R Lines 3 to 4 in cf25541
|
cf25541
to
a80acf4
Compare
You're right. It doesn't provide the coverage I wanted. I think there should be a vcr response for if |
Hi @RichardLitt, where are you at with this? I've tried running these tests locally and they seem to be blocking IP addresses as expected. |
I removed the unnecessary lines, and this should be good to go if it works for you. Thank you! |
@slager is this working as expected for you? |
Closes #115.