Skip to content

fixing tests #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fixing tests #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7ca3c3
fixing tests
b-rodrigues Sep 18, 2024
6d0386f
start using withr to deal with local tempfiles
b-rodrigues Sep 18, 2024
d6abbfb
Style via {styler}
b-rodrigues Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions R/with_nix.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,12 @@ with_nix <- function(expr,
if (nzchar(LD_LIBRARY_PATH_default)) {
# set old LD_LIBRARY_PATH (only if system's R session and if it wasn't
# `""`)
on.exit({
Sys.setenv(LD_LIBRARY_PATH = LD_LIBRARY_PATH_default)
},
add = TRUE)
on.exit(
{
Sys.setenv(LD_LIBRARY_PATH = LD_LIBRARY_PATH_default)
},
add = TRUE
)
}
}

Expand Down
1 change: 1 addition & 0 deletions default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ let
rmarkdown
styler
sys
withr
testthat;
};

Expand Down
120 changes: 53 additions & 67 deletions tests/testthat/test-rix.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ testthat::test_that("rix(), ide is 'rstudio', Linux", {
)
dir.create(path_default_nix)
path_default_nix <- normalizePath(path_default_nix)
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)

save_default_nix_test <- function(ide, path_default_nix) {
rix(
Expand Down Expand Up @@ -39,11 +43,6 @@ testthat::test_that("rix(), ide is 'rstudio', Linux", {
path = save_default_nix_test(ide = "rstudio", path_default_nix),
name = "rstudio_default.nix",
)

on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})


Expand All @@ -53,6 +52,10 @@ testthat::test_that("rix(), ide is 'other' or 'code'", {
)
dir.create(path_default_nix)
path_default_nix <- normalizePath(path_default_nix)
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)

save_default_nix_test <- function(ide, path_default_nix) {
# We need to add this because this function gets called
Expand Down Expand Up @@ -105,16 +108,15 @@ testthat::test_that("rix(), ide is 'other' or 'code'", {
),
name = "code_default.nix"
)

on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})


testthat::test_that("Quarto gets added to sys packages", {
path_default_nix <- normalizePath(tempdir())
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)

save_default_nix_test <- function(pkgs, interface, path_default_nix) {
# Because of rix_init, see above
Expand Down Expand Up @@ -153,17 +155,16 @@ testthat::test_that("Quarto gets added to sys packages", {
),
name = "yes_quarto_default.nix"
)

on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})

testthat::test_that("If on darwin and ide = rstudio, raise warning", {
skip_if(Sys.info()["sysname"] != "Darwin")

path_default_nix <- normalizePath(tempdir())
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)

save_default_nix_test <- function(path_default_nix) {
rix(
Expand All @@ -182,15 +183,14 @@ testthat::test_that("If on darwin and ide = rstudio, raise warning", {
save_default_nix_test(path_default_nix),
regexp = "refer to the macOS"
)
})

testthat::test_that("If R version is 4.4.0, raise warning", {
path_default_nix <- tempdir()
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})

testthat::test_that("If R version is 4.4.0, raise warning", {
path_default_nix <- tempdir()

save_default_nix_test <- function(path_default_nix) {
rix(
Expand All @@ -209,15 +209,14 @@ testthat::test_that("If R version is 4.4.0, raise warning", {
save_default_nix_test(path_default_nix),
regexp = "version is not available"
)
})

testthat::test_that("If R version is <= 4.1.1, raise warning", {
path_default_nix <- tempdir()
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})

testthat::test_that("If R version is <= 4.1.1, raise warning", {
path_default_nix <- tempdir()

save_default_nix_test <- function(path_default_nix) {
rix(
Expand All @@ -236,16 +235,14 @@ testthat::test_that("If R version is <= 4.1.1, raise warning", {
save_default_nix_test(path_default_nix),
regexp = "older version of R"
)
})


testthat::test_that("If on ide = rstudio, but no R packages, raise error", {
path_default_nix <- tempdir()
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})

testthat::test_that("If on ide = rstudio, but no R packages, raise error", {
path_default_nix <- tempdir()

save_default_nix_test <- function(path_default_nix) {
rix(
Expand All @@ -264,15 +261,14 @@ testthat::test_that("If on ide = rstudio, but no R packages, raise error", {
save_default_nix_test(path_default_nix),
regexp = "didn't add any R packages"
)
})

testthat::test_that("If R version is == 3.5.3, raise warning", {
path_default_nix <- tempdir()
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})

testthat::test_that("If R version is == 3.5.3, raise warning", {
path_default_nix <- tempdir()

save_default_nix_test <- function(path_default_nix) {
rix(
Expand All @@ -291,11 +287,6 @@ testthat::test_that("If R version is == 3.5.3, raise warning", {
save_default_nix_test(path_default_nix),
regexp = "older version of R"
)

on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})

testthat::test_that("rix(), bleeding_edge", {
Expand All @@ -304,6 +295,10 @@ testthat::test_that("rix(), bleeding_edge", {
)
dir.create(path_default_nix)
path_default_nix <- normalizePath(path_default_nix)
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)

save_default_nix_test <- function(ide, path_default_nix) {
# This will generate the warning to read the vignette for bleeding_edge
Expand Down Expand Up @@ -340,11 +335,6 @@ testthat::test_that("rix(), bleeding_edge", {
path = save_default_nix_test(ide = "other", path_default_nix),
name = "bleeding_edge_default.nix",
)

on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})

testthat::test_that("rix(), frozen_edge", {
Expand All @@ -356,6 +346,15 @@ testthat::test_that("rix(), frozen_edge", {
)
dir.create(path_default_nix)
path_default_nix <- normalizePath(path_default_nix)
on.exit(
{
system(
paste0("sed -i 's/", frozen_edge_commit, "/REVISION/' _snaps/rix/frozen_edge_default.nix")
)
unlink(path_default_nix, recursive = TRUE, force = FALSE)
},
add = TRUE
)

save_default_nix_test <- function(ide, path_default_nix) {
# This will generate the warning to read the vignette for bleeding_edge
Expand Down Expand Up @@ -398,16 +397,6 @@ testthat::test_that("rix(), frozen_edge", {
path = save_default_nix_test(ide = "other", path_default_nix),
name = "frozen_edge_default.nix",
)


on.exit({
system(
paste0("sed -i 's/", frozen_edge_commit, "/REVISION/' _snaps/rix/frozen_edge_default.nix")
)
unlink(path_default_nix, recursive = TRUE, force = FALSE)
},
add = TRUE
)
})


Expand All @@ -417,6 +406,10 @@ testthat::test_that("rix(), only one Github package", {
)
dir.create(path_default_nix)
path_default_nix <- normalizePath(path_default_nix)
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)

save_default_nix_test <- function(path_default_nix) {
rix(
Expand All @@ -442,11 +435,6 @@ testthat::test_that("rix(), only one Github package", {
path = save_default_nix_test(path_default_nix),
name = "one_git_default.nix",
)

on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})


Expand All @@ -456,6 +444,10 @@ testthat::test_that("rix(), conclusion message", {
)
dir.create(path_default_nix)
path_default_nix <- normalizePath(path_default_nix)
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)

save_default_nix_test <- function(path_default_nix) {
rix(
Expand All @@ -473,11 +465,6 @@ testthat::test_that("rix(), conclusion message", {
save_default_nix_test(path_default_nix),
regexp = "Successfully"
)

on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})


Expand All @@ -489,6 +476,10 @@ testthat::test_that("rix(), warning message if rix_init() already called", {
)
dir.create(path_default_nix)
path_default_nix <- normalizePath(path_default_nix)
on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)

rix_init(
project_path = path_default_nix,
Expand Down Expand Up @@ -521,9 +512,4 @@ testthat::test_that("rix(), warning message if rix_init() already called", {
save_default_nix_test(path_default_nix),
regexp = "You may"
)

on.exit(
unlink(path_default_nix, recursive = TRUE, force = TRUE),
add = TRUE
)
})
16 changes: 0 additions & 16 deletions vignettes/a-getting-started.R
View file
Open in desktop

This file was deleted.

Loading