Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add workflow to test on humble #329

Merged
merged 2 commits into from
May 20, 2024
Merged

[CI] Add workflow to test on humble #329

merged 2 commits into from
May 20, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented May 18, 2024

I discussed with @saikishor that we want to keep the gazebo_ros2_control alive because the rolling version of gz_ros2_control can't be easily installed on jammy, see ros-controls/ros2_control_ci#82

To test the rolling version here I re-add a workflow (deleted with #314), but test it on the humble distro by building the whole rolling ros2_control stack as we do here

@christophfroehlich christophfroehlich marked this pull request as draft May 18, 2024 08:47
@christophfroehlich christophfroehlich marked this pull request as ready for review May 18, 2024 09:09
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @christophfroehlich. It is better for now to have a tag in gazebo_ros2_control rolling that works on older distros. We would like to maintain the rolling version compilable and working for other users who would like to compile and release in their CIs for Humble and Iron.

@ahcorde what do you think about this?

@ahcorde ahcorde merged commit f901ba9 into master May 20, 2024
5 checks passed
@ahcorde ahcorde deleted the test_on_humble branch May 20, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants