Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use humble branch of control_toolbox repo #258

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

christophfroehlich
Copy link
Contributor

No description provided.

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble. label Jan 15, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (5b85370) to head (dc3d280).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   70.12%   70.12%           
=======================================
  Files           8        8           
  Lines         492      492           
  Branches       84       84           
=======================================
  Hits          345      345           
  Misses         92       92           
  Partials       55       55           
Flag Coverage Δ
unittests 70.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but should go into master?

@christophfroehlich
Copy link
Contributor Author

OK, but should go into master?

its easier if the files are the same on every branch, otherwise it's always a mess with future backports

@christophfroehlich christophfroehlich merged commit db891ef into master Jan 16, 2025
18 checks passed
@christophfroehlich christophfroehlich deleted the update/ct/humble branch January 16, 2025 21:05
mergify bot pushed a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants