Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test unload_on_kill_activate_as_group fails on jazzy/testing #1753

Open
christophfroehlich opened this issue Sep 15, 2024 · 6 comments
Open
Labels

Comments

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Sep 15, 2024

2024-09-13T02:29:16.7694364Z 9: /home/runner/work/ros2_control/ros2_control/.work/target_ws/src/ros2_control/controller_manager/test/test_spawner_unspawner.cpp:347: Failure
2024-09-13T02:29:16.7694540Z 9: Expected equality of these values:
2024-09-13T02:29:16.7694700Z 9:   cm_->get_loaded_controllers().size()
2024-09-13T02:29:16.7694790Z 9:     Which is: 2
2024-09-13T02:29:16.7694871Z 9:   0ul
2024-09-13T02:29:16.7694961Z 9:     Which is: 0
2024-09-13T02:29:16.7704118Z 9: 

see #1751 and https://github.com/ros-controls/ros2_control/actions/runs/10841825910/attempts/1

@christophfroehlich
Copy link
Contributor Author

@saikishor could you have a look maybe?

@saikishor
Copy link
Member

@christophfroehlich Is it failing more frequently?

@saikishor
Copy link
Member

     [INFO] [1726194509.916911268] [spawner_ctrl_3]: [NON-XML-CHAR-0x1B][92mConfigured and activated all the parsed controllers list : ['ctrl_3', 'ctrl_2']![NON-XML-CHAR-0x1B][0m
    [INFO] [1726194509.917833389] [spawner_ctrl_3]: Waiting until interrupt to unload controllers
    /home/runner/work/ros2_control/ros2_control/.work/target_ws/src/ros2_control/controller_manager/test/test_spawner_unspawner.cpp:347: Failure
    Expected equality of these values:
      cm_->get_loaded_controllers().size()
        Which is: 2
      0ul
        Which is: 0

Seems like it didn't catch the keyboard interrupt. Let's wait to see if this happens more often.

Thank you!

@christophfroehlich
Copy link
Contributor Author

Now and then, but at the next try it succeeded

@saikishor
Copy link
Member

Now and then, but at the next try it succeeded

Gotcha! We should keep an eye on this.

@christophfroehlich
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants