Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ros2_control_node to documentation #1821

Open
christophfroehlich opened this issue Oct 29, 2024 · 3 comments
Open

Add ros2_control_node to documentation #1821

christophfroehlich opened this issue Oct 29, 2024 · 3 comments

Comments

@christophfroehlich
Copy link
Contributor

I realized that we don't mention the ros2_control_node not even once in the docs. Should we?

Originally posted by @christophfroehlich in #1820 (review)

@fmauch
Copy link
Contributor

fmauch commented Oct 30, 2024

This is not entirely true, as we mention it e.g. here but it could definitely placed more visible.

Should we add and explain a minimal launch file with

  • description
  • controller config file
  • robot state publisher
  • ros2_control_node
  • controller spawner
  • RViz

This almost boils down to the launch setup from example1, so we could just try to explain that a bit more in detail and link to that explanation from the getting_started page?

@christophfroehlich
Copy link
Contributor Author

ah, you are right. In the demos we don't explain what this node is for. I would maybe extend the get started section a bit, and describe parameters like introduced with #1820? And then link to example_1.

@saikishor
Copy link
Member

ah, you are right. In the demos we don't explain what this node is for. I would maybe extend the get started section a bit, and describe parameters like introduced with #1820? And then link to example_1.

Yes! some overview of the parameters and what is is used for and a link to an example should do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants