Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strong typed return type of the helper methods #1942

Open
saikishor opened this issue Dec 15, 2024 · 1 comment · May be fixed by #1981
Open

Add strong typed return type of the helper methods #1942

saikishor opened this issue Dec 15, 2024 · 1 comment · May be fixed by #1981
Assignees
@Wiktor-99
Labels
good first issue

Comments

@saikishor
Copy link
Member 

          That being said if we wanted to go fully proper, I'd say a strongly typed "VelocityLimits" and "AccelerationLimits" would not be too bad either so it is easier to track down if they are used in the right places... --- just an idea, not for this PR

Originally posted by @bmagyar in #1526 (comment)
@Wiktor-99
Copy link
Contributor

I can carry on this case

@Wiktor-99 Wiktor-99 linked a pull request Jan 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wiktor-99 Wiktor-99

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add strog type for limits Wiktor-99/ros2_control
2 participants
@saikishor @Wiktor-99