Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a defaults.yaml file for source build #139

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

christophfroehlich
Copy link
Contributor

Test stage of source builds fail regularily, like ros-controls/ros2_controllers#1299

The log is very confusing, then I realized that the action-ros-ci runs the tests in parallel, while ICI uses --executor sequential argument. I added a defaults yaml for the action-ros-ci, which should improve this

https://colcon.readthedocs.io/en/released/reference/executor-arguments.html
https://github.com/ros-tooling/action-ros-ci/blob/3e19c804cebf096f76de1b07ddd1cb52b5a2b8e3/action.yml#L8C3-L8C19

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to make sense and the syntax also looks correct.

@christophfroehlich christophfroehlich merged commit d3a6346 into master Oct 8, 2024
2 checks passed
@christophfroehlich christophfroehlich deleted the source_build_sequential branch October 8, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants