Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add path-filters and fix branches for check-docs #519

Merged
merged 4 commits into from
May 14, 2024
Merged

[CI] Add path-filters and fix branches for check-docs #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dd2a9a
Fix branches for check-docs
christophfroehlich May 13, 2024
9797aab
Fix iron
christophfroehlich May 13, 2024
c36f925
Add path filters
christophfroehlich May 13, 2024
894bc0c
Include workflow file to paths filter
christophfroehlich May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/humble-binary-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,29 @@ on:
pull_request:
branches:
- humble
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/humble-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos-not-released.humble.repos'
Comment on lines +8 to +17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophfroehlich are these paths used to check for the changes in the files and then run the CI only if there are changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly. if one changes only rst files, we don't run unnecessary CI checks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophfroehlich Should we add these filters in other repos as well?. In case, we touch only the documentation, so it won't launch the unnecessary CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ros-controls/ros2_control#1521
ros-controls/ros2_controllers#1114
;)

push:
branches:
- humble
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/humble-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos-not-released.humble.repos'
schedule:
# Run every morning to detect flakiness and broken dependencies
- cron: '03 1 * * *'
Expand Down
17 changes: 17 additions & 0 deletions .github/workflows/humble-check-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Humble Check Docs

on:
workflow_dispatch:
pull_request:
branches:
- humble
paths:
- '**.rst'
- '.github/workflows/humble-check-docs.yml'

jobs:
check-docs:
name: Check Docs
uses: ros-controls/control.ros.org/.github/workflows/reusable-sphinx-check-single-version.yml@humble
with:
ROS2_CONTROL_DEMOS_PR: ${{ github.ref }}
20 changes: 20 additions & 0 deletions .github/workflows/humble-semi-binary-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,29 @@ on:
pull_request:
branches:
- humble
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/humble-semi-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos.humble.repos'
push:
branches:
- humble
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/humble-semi-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos.humble.repos'
schedule:
# Run every morning to detect flakiness and broken dependencies
- cron: '33 1 * * *'
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/iron-binary-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,29 @@ on:
pull_request:
branches:
- iron
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/iron-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos-not-released.iron.repos'
push:
branches:
- iron
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/iron-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos-not-released.iron.repos'
schedule:
# Run every morning to detect flakiness and broken dependencies
- cron: '03 1 * * *'
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/ci-check-docs.yml → .github/workflows/iron-check-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
name: Check Docs
name: Iron Check Docs

on:
workflow_dispatch:
pull_request:
branches:
- iron
paths:
- '**.rst'
- '.github/workflows/iron-check-docs.yml'

jobs:
check-docs:
name: Check Docs
uses: ros-controls/control.ros.org/.github/workflows/reusable-sphinx-check-single-version.yml@master
uses: ros-controls/control.ros.org/.github/workflows/reusable-sphinx-check-single-version.yml@iron
with:
ROS2_CONTROL_DEMOS_PR: ${{ github.ref }}
22 changes: 22 additions & 0 deletions .github/workflows/iron-docker-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,31 @@ on:
pull_request:
branches:
- iron
paths:
- '**.hpp'
- '**.cpp'
- Dockerfile/**
- '.github/workflows/iron-docker-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos.iron.repos'
push:
branches:
- iron
paths:
- '**.hpp'
- '**.cpp'
- Dockerfile/**
- '.github/workflows/iron-docker-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos.iron.repos'
schedule:
# Run every morning to detect broken dependencies
- cron: '50 1 * * *'
Expand Down
21 changes: 21 additions & 0 deletions .github/workflows/iron-semi-binary-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,30 @@ on:
pull_request:
branches:
- iron
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/iron-semi-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos.iron.repos'
push:
branches:
- iron
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/iron-semi-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos.iron.repos'

schedule:
# Run every morning to detect flakiness and broken dependencies
- cron: '33 1 * * *'
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/rolling-binary-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,29 @@ on:
pull_request:
branches:
- master
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/rolling-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos-not-released.rolling.repos'
push:
branches:
- master
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/rolling-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos-not-released.rolling.repos'
schedule:
# Run every morning to detect flakiness and broken dependencies
- cron: '03 1 * * *'
Expand Down
23 changes: 23 additions & 0 deletions .github/workflows/rolling-check-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Rolling Check Docs

on:
workflow_dispatch:
pull_request:
branches:
- master
paths:
- '**.rst'
- '.github/workflows/rolling-check-docs.yml'


jobs:
check-docs-rolling:
name: Check Docs
uses: ros-controls/control.ros.org/.github/workflows/reusable-sphinx-check-single-version.yml@rolling
with:
ROS2_CONTROL_DEMOS_PR: ${{ github.ref }}
check-docs-jazzy:
name: Check Docs
uses: ros-controls/control.ros.org/.github/workflows/reusable-sphinx-check-single-version.yml@jazzy
with:
ROS2_CONTROL_DEMOS_PR: ${{ github.ref }}
22 changes: 22 additions & 0 deletions .github/workflows/rolling-docker-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,31 @@ on:
pull_request:
branches:
- master
paths:
- '**.hpp'
- '**.cpp'
- Dockerfile/**
- '.github/workflows/rolling-docker-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos.rolling.repos'
push:
branches:
- master
paths:
- '**.hpp'
- '**.cpp'
- Dockerfile/**
- '.github/workflows/rolling-docker-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos.rolling.repos'
schedule:
# Run every morning to detect broken dependencies
- cron: '50 1 * * *'
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/rolling-semi-binary-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,29 @@ on:
pull_request:
branches:
- master
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/rolling-semi-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos.rolling.repos'
push:
branches:
- master
paths:
- '**.hpp'
- '**.cpp'
- '.github/workflows/rolling-semi-binary-build.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- '**.xacro'
- '**.py'
- '**.yaml'
- 'ros2_control_demos.rolling.repos'
schedule:
# Run every morning to detect flakiness and broken dependencies
- cron: '33 1 * * *'
Expand Down
Loading