Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS-O] drop outdated standard #268

Closed
wants to merge 1 commit into from
Closed

Conversation

v4hn
Copy link

@v4hn v4hn commented Sep 27, 2023

to support Ubuntu jammy+

@JWhitleyWork
Copy link
Contributor

@v4hn The last ROS1 release (which main is targeted at) is noetic which only supports Ubuntu Focal (20.04). Therefore this change is unnecessary. If you're looking for ROS2 on Jammy, try the ros2 branch.

@v4hn
Copy link
Author

v4hn commented Feb 23, 2024

Hi Joshua,

I'm surprised you would respond that way after accepting #239 a few months ago.
The only reason this trivial patch is needed is because #255 was merged after that.

If you intend to reject any further fixes to support new upstream deps for political reasons, it would be nice if you could indicate somewhere that https://github.com/ros-o/joystick_drivers might be used for such systems.
I'm happy to provide a pull-request to add a note to the readme if you prefer that.

The last ROS1 release (which main is targeted at) is noetic which only supports Ubuntu Focal (20.04).

RoboStack, Debian Science Robotics ROS, several ROS-O builders 1 2 3, and other external build scripts, all of them needing this patch if they build wiimote, politely disagree.
Anecdotally, a colleague just ran apt install rviz on a Raspberry 5 / Debian bookworm yesterday and built a whole MoveIt stack on top to control an anthropomorphic head. I expect he will need joystick support soon. 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants