Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/exercise 3.3 moveit config pkg #356

Merged

Conversation

jrgnicho
Copy link
Member

@jrgnicho jrgnicho commented Oct 1, 2021

Updates the exercise moveit_config package in accordance to the changes in #335

@jrgnicho jrgnicho changed the title Fix/exercise 3.0 moveit config pkg Fix/exercise 3.3 moveit config pkg Oct 1, 2021
@jdlangs jdlangs force-pushed the fix/exercise-3.0-moveit_config_pkg branch from e8a7000 to a8abb0b Compare October 6, 2021 15:32
@jdlangs jdlangs force-pushed the fix/exercise-3.0-moveit_config_pkg branch from a8abb0b to 39e568b Compare October 6, 2021 15:36
@jdlangs
Copy link
Member

jdlangs commented Oct 6, 2021

Refactored this a bit more to be closer to the original package setup. Note this depends on the xacro modifications to be done in #357 but for now only touches the moveit package. I propose we do a "syncing" PR afterwards with the sole purpose of making sure later exercises contain the most up-to-date solutions of earlier exercises.

@jdlangs
Copy link
Member

jdlangs commented Oct 6, 2021

Updated instructions as well, this is ready to merge now.

@jdlangs jdlangs merged commit 2add68a into ros-industrial:foxy Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants