-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sda10f urdf #271
Fix sda10f urdf #271
Conversation
@asierfernandez: CI seems to fail for Can you check locally? |
I'll check it next week |
Looks like the |
Getting back to this: the urdf is fixed, but the origins of the meshes are not updated in this PR, which leads to rendering issues (and potential problems with MoveIt's collision detection/avoidance). Not asking @asierfernandez to fix that after all this time, just making a note about this here. Example: |
We didn't pay attention to meshes, because we were only interested on solving properly the IK. |
Just to make sure we don't accidentally merge this in, I'm going to submit a review with request changes. Thanks for the additional info @asierfernandez. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mesh origins would need to be updated as well.
We now have #321, which I believe will address the issues raised here as well. Thanks @asierfernandez for the initial PR 👍 |
We propose a more accurate urdf for sda10f robot. Updated dimensions have been extracted from 3D CAD model as described in #232