Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sda10f urdf #271

Conversation

asierfernandez
Copy link

We propose a more accurate urdf for sda10f robot. Updated dimensions have been extracted from 3D CAD model as described in #232

@gavanderhoorn
Copy link
Member

@asierfernandez: CI seems to fail for motoman_sda10f_support with the proposed change.

Can you check locally?

@asierfernandez
Copy link
Author

@asierfernandez: CI seems to fail for motoman_sda10f_support with the proposed change.

Can you check locally?

@asierfernandez: CI seems to fail for motoman_sda10f_support with the proposed change.

Can you check locally?

I'll check it next week

@gavanderhoorn
Copy link
Member

Looks like the joint_limited param was the problem.

@gavanderhoorn
Copy link
Member

gavanderhoorn commented Aug 28, 2019

Getting back to this: the urdf is fixed, but the origins of the meshes are not updated in this PR, which leads to rendering issues (and potential problems with MoveIt's collision detection/avoidance).

Not asking @asierfernandez to fix that after all this time, just making a note about this here.

Example:

rviz_screenshot_2019_08_28-17_24_29

@asierfernandez
Copy link
Author

We didn't pay attention to meshes, because we were only interested on solving properly the IK.
Meshes should also be updated, but unfortunately we won't work on that in the next months.
@gavanderhoorn thanks for the comment!

@gavanderhoorn
Copy link
Member

Just to make sure we don't accidentally merge this in, I'm going to submit a review with request changes.

Thanks for the additional info @asierfernandez.

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mesh origins would need to be updated as well.

@gavanderhoorn
Copy link
Member

We now have #321, which I believe will address the issues raised here as well.

Thanks @asierfernandez for the initial PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants