Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GP20HL Support Package #566

Closed
wants to merge 1 commit into from

Conversation

acbuynak
Copy link
Contributor

@acbuynak acbuynak commented Sep 2, 2023

Add support package for Yaskawa Motoman GP20HL robot.

If requested, I can draft a GP20 URDF model but I would not be able to verify on hardware. The GP20 model appears to be less common and maybe only distributed in EU?

This support package and URDF have been tested with real hardware and the joint directions verified. All joint motion in RViz match physical motion.

@gavanderhoorn
Copy link
Member

This might have been duplicated in #604.

@gavanderhoorn
Copy link
Member

@acbuynak: thank you for opening the PR and for making the effort to share the model.

As mentioned by @EricMarcil in #604 (comment):

No, it is a new one that I made. I must have missed the #566 that was made by @acbuynak.
I used the MotoSim model to generate the visual meshes in .dae which keeps the colors of the orignial model. So, I would prefer to keep #604.

We'll close this one in favour of #604 then.

I'll compare the files in this PR against those in #604, just to see if there are any discrepancies.

<child link="${prefix}link_1_s"/>
<origin xyz="0 0 0.540" rpy="0 0 0" />
<axis xyz="0 0 1" />
<limit lower="-${radians(180)}" upper="${radians(180)}" effort="212.66" velocity="${radians(125)}"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the velocity limits in this file appear to be different from the model in #604.

@EricMarcil: would you have any idea why that could be?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavanderhoorn No, I do not. I've double checked the values on #604 with two separate sources: the manual and the parameter data from MotoSim, and the values on #604 are the correct ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over my project history and don't see any reason why the 125 deg/sec velocity was set. I agree that the datasheet I pulled down today reports 180 deg/sec that @EricMarcil used in his PR.

I'd recommend closing this PR. Thanks for the review @gavanderhoorn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both @acbuynak and @EricMarcil.

@acbuynak: thank you for submitting the PR.

Given the state of things I'll close this one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants