-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GP20HL Support Package #566
Conversation
This might have been duplicated in #604. |
@acbuynak: thank you for opening the PR and for making the effort to share the model. As mentioned by @EricMarcil in #604 (comment):
We'll close this one in favour of #604 then. I'll compare the files in this PR against those in #604, just to see if there are any discrepancies. |
<child link="${prefix}link_1_s"/> | ||
<origin xyz="0 0 0.540" rpy="0 0 0" /> | ||
<axis xyz="0 0 1" /> | ||
<limit lower="-${radians(180)}" upper="${radians(180)}" effort="212.66" velocity="${radians(125)}"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the velocity limits in this file appear to be different from the model in #604.
@EricMarcil: would you have any idea why that could be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gavanderhoorn No, I do not. I've double checked the values on #604 with two separate sources: the manual and the parameter data from MotoSim, and the values on #604 are the correct ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over my project history and don't see any reason why the 125 deg/sec velocity was set. I agree that the datasheet I pulled down today reports 180 deg/sec that @EricMarcil used in his PR.
I'd recommend closing this PR. Thanks for the review @gavanderhoorn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both @acbuynak and @EricMarcil.
@acbuynak: thank you for submitting the PR.
Given the state of things I'll close this one now.
Add support package for Yaskawa Motoman GP20HL robot.
If requested, I can draft a GP20 URDF model but I would not be able to verify on hardware. The GP20 model appears to be less common and maybe only distributed in EU?
This support package and URDF have been tested with real hardware and the joint directions verified. All joint motion in RViz match physical motion.