test_<model>.launch files update #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the test_<model>.launch files to use the "joint_state_publisher_gui" instead of the "joint_state_publisher" so that the joint slide controls are displayed with RViz.
gavanderhoorn
requested changes
Sep 26, 2024
There was a problem hiding this comment.
It won't make CI green for Kinetic or Melodic, but if we change this, we must update the package.xml to state the dependency on joint_state_publisher_gui (instead of the current joint_state_publisher).
Like in:
motoman/motoman_gp110_support/package.xml
Line 44 in 433be15
Updated dependency in package.xml
|
@gavanderhoorn Updated the package,xml files dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the test_.launch files to use the "joint_state_publisher_gui" instead of the "joint_state_publisher" so that the joint slide controls are displayed with RViz.