Use 'host' network in deb container builds #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --network argument was added to 'docker build' in Docker 1.13 in 2017 and behaves like the --net argument to 'docker run'. We're already using --net=host during the actual deb build and during all of the RPM containers. The change here is to also use host networking during the build phase. The intent here is to support more self-contained building scenarios where a repository may be on localhost.
nuclearsandwich
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --network argument was added to 'docker build' in Docker 1.13 in 2017 and behaves like the --net argument to 'docker run'.
We're already using --net=host during the actual deb build and during all of the RPM containers. The change here is to also use host networking during the build phase.
The intent here is to support more self-contained building scenarios where a repository may be on localhost.
Both build.ros.org and build.ros2.org use sufficient Docker engines to support this feature.