Plumb 'build_environment_variables' into doc jobs #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This buildfarm configuration variable has always been included for doc job configurations, but has been left unused. With this change, those variables are now used in 'doc' and 'rosdoc2' jobs in the same way that they're used for devel, CI, and release jobs.
|
It looks like we've had a ROS_PYTHON_VERSION variable defined in the buildfarm config for rosdoc2 jobs since day 1, and it appears that it gets plumbed through correctly with this change (at least, according to the GitHub Actions jobs). |
nuclearsandwich
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This buildfarm configuration variable has always been included for doc job configurations, but has been left unused. With this change, those variables are now used in 'doc' and 'rosdoc2' jobs in the same way that they're used for devel, CI, and release jobs.
This should be a non-breaking change that doesn't require a staged rollout to the buildfarm because the newly added
--env-varsargument to the scripts is optional, so it should be OK for the buildfarm to continue consuming HEAD even though the change hasn't been deployed to the Jenkins jobs yet.