-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rosdep only shows the last resolution error for each package #747
Comments
@cottsay, take a gander. Are my expectations wrong? |
First, I'll note that I think the behavior you're seeing is that only the With the difference in behavior explained, there are two things that need to happen:
An improvement to clarify this situation would be to |
Why is only the first missing dependency reported? Shouldn't |
I would assume that I'm making a guess at this point, though. We should look at the code. |
Could you try running |
I confirmed this myself. Here is the spot where the problem occurs: Lines 420 to 423 in cfa21c8
While I was on the right track in describing the behavior, I missed the mark on the cause. Resolution happens for every key in the package, but only the last error gets reported. Seems like a great opportunity for a PR that makes the behavior more expected. |
Yeah and adding libpcl-all to the rosdep
|
FYI, @cottsay: Also posted https://answers.ros.org/question/348230/how-do-i-use-rosdep-install/. I'm missing some very foundational knowledge about this tool. |
@rotu so let me summarize what my understanding here is:
1 is easy, its not released or the key doesn't exist for the OS, you can easily submit a PR for it if the binaries are being built for it. If not, poking maintainers to release the binraries so then you can update the rosdep list. Ok, done. 2 and 3 sound like rosdep issues, no particular action item for me? |
@rotu how did you solved it for pcl_conversiosns/perception_pcl I am having the almost same problem but this time my personal system is working fine and providing error:-
On my personal system:-
is able to find them
but on circle ci it's not working. |
@SteveMacenski, correct. This is not particular to ouster or PCL stuff; they are just where I saw this behavior. @ShivamPR21 I can’t say for certain. It does look like the foxy release for |
Nope, it's still not working. |
I'm building
ros2_ouster
from source on Ubuntu Focal against ROS2 Master, which depends on pcl_conversions and libpcl-allWhile rosdep shows a warning for
libpcl-all
, it does not show a warning forpcl_conversions
:It's also missing from
rosdep check
:Spoofing my os version to bionic causes the missing key to show up:
The text was updated successfully, but these errors were encountered: