Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libpcl-dev, libpcl-all-dev for Focal #24331

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Add libpcl-dev, libpcl-all-dev for Focal #24331

merged 3 commits into from
Apr 3, 2020

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Apr 2, 2020 •
edited
Loading

@rotu rotu requested a review from a team as a code owner April 2, 2020 17:31
@cottsay
Copy link
Member

cottsay commented Apr 2, 2020

From the CONTRIBUTING.md:

For convenience in reviewing, please comment in the PR with links to the web listings of packages such as on http://packages.ubuntu.com

@cottsay cottsay added the rosdep Issue/PR is for a rosdep key label Apr 2, 2020
@cottsay
Copy link
Member

cottsay commented Apr 2, 2020

Here is a direct, unambiguous link to the package backing this new rule: https://packages.ubuntu.com/focal/libpcl-dev

If I'm not mistaken, the missing rule in ros-infrastructure/rosdep#747 is for the libpcl-all key, not libpcl-all-dev.

@rotu rotu changed the title Add libpcl-dev for Focal Add libpcl-dev, libpcl-all for Focal Apr 2, 2020
@rotu rotu changed the title Add libpcl-dev, libpcl-all for Focal Add libpcl-dev, libpcl-all-dev for Focal Apr 2, 2020
@rotu
Copy link
Contributor Author

rotu commented Apr 2, 2020

you're right and I intended to add both.

cottsay
cottsay approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the packages in the list appear to exist in Focal, and there don't appear to be any new subpackages in PCL 1.10 that should be added.

@cottsay
Copy link
Member

cottsay commented Apr 2, 2020

@rotu - this change looks fine, but you need to fix CI for us to merge it.

@cottsay cottsay requested a review from a team April 2, 2020 18:25
@rotu
Copy link
Contributor Author

rotu commented Apr 2, 2020

Oops! CI fixed

@clalancette clalancette merged commit d54b893 into ros:master Apr 3, 2020
sloretz pushed a commit that referenced this pull request Aug 5, 2020
@rotu @sloretz
Add libpcl-dev, libpcl-all-dev for Focal (#24331)
668a544 
* Add libpcl-dev for Focal

* add libpcl-all for focal

* Remove extra whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottsay cottsay cottsay approved these changes

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rotu @cottsay @clalancette