Fixes for Windows #811
Merged
Fixes for Windows #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 74.96% 74.87% -0.09%
==========================================
Files 42 42
Lines 3283 3308 +25
==========================================
+ Hits 2461 2477 +16
- Misses 822 831 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
One comment about the change in exit code on error. If I was certain the exit code should be non-zero I would make the change myself and merge the PR but I want to get feedback from @Tobias-Fischer to make sure there's not some reason the program should exit cleanly here.
|
All done now - would be great if you could have another look @nuclearsandwich |
nuclearsandwich
approved these changes
Jul 1, 2021
|
Thanks @Tobias-Fischer! |
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a minimal set of changes from #661 to get the RoboStack installer (#810) to work on Windows.
@nuclearsandwich already had a look at #661 and the last comment was to rework the Azure pipeline to use GitHub actions instead; in this PR I'm taking a more minimal approach and only pull in easy-to-review changes without touching tests etc. which we don't need for our RoboStack use-case.
The contents of the PR are already used within the conda-forge build of rosdep (see https://github.com/conda-forge/rosdep-feedstock). We confirmed that Windows works in our moveit PR to add cross-platform CI (moveit/moveit#2604) which makes use of rosdep.
/cc @wolfv @traversaro