Fix for issue #819 - adding ability to deal with pip packages installed via git #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested fix for issue ros-infrastructure#819
|
What is the desired behavior if a package is already installed from PyPI and a rosdep rule requests the package be installed from a specific git URL like this? From what I can tell, this change will leave the package alone. |
|
My 2 cents would be to have it prioritize the version from the specific URL and reinstall that fixed one with the assumption that it is an intentional development override; perhaps it should throw an alert/WARNING when doing so? Fixed URL packages do break traditional version tracking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested fix for issue #819