-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apt install all at once #990
Closed
MrBlenny
wants to merge
39
commits into
ros-infrastructure:master
from
Greenroom-Robotics:apt_install_all_at_once
Closed
Apt install all at once #990
MrBlenny
wants to merge
39
commits into
ros-infrastructure:master
from
Greenroom-Robotics:apt_install_all_at_once
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…david_revay/sc-4323/version-pinning-in-package-xml
feat: deb and pip version pinning in package xml [sc-4323]
* fix: change order of installers * chore(ci): only interested in relevant versions of python
* chore(ci): only interested in relevant versions of python * fix: make the mods less breaking * fix: don't try and get version info from RosDep objs
ros-infrastructure#809) Co-authored-by: Scott K Logan <[email protected]>
Also drop PR branch wildcard to align with other ROS infrastructure CI workflows.
Also make the 'mock' dependency conditional, now that this package supports using unittest.mock.
…#884) Marking tests appropriately will allow us to be more selective about what tests are run.
When our Python packages are split into a separate `-modules` subpackage, it appears that the pattern is to retain the package distribution information in the main package, which contains the scripts. When our packages take dependencies on only the `-modules` subpackage, they need to omit the Python dependencies to prevent `pkg_resources` from looking for those missing packages. Instead, we rely on apt and dpkg to ensure that the dependencies are present. This shouldn't have any affect on non-debian installation of rosdep.
…cture#888) These asserts check that nothing was written to stderr during some top-level rosdep invocations. On derivative platforms like CentOS and AlmaLinux, a message is written to stderr during normal operation stating that the platform is an alias to the parent platform (RHEL, in this example). This is normal and expected behavior on those platforms, so the tests should still pass there.
I was tired of seeing this in docker build logs
This should make the installation faster.
…osdep into apt_install_all_at_once
tfoote
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general we could consider making a change to install . There's already a smaller change in #953 which has a bunch of discussion on it. I'd suggest following up over there.
Oops sorry, this was meant to go into our fork 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.