Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stack exchange api for questions #417

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

rkent
Copy link

@rkent rkent commented Sep 9, 2024

Fixes #354

I switched to the questions API, and the CORS issues go away.

I modernized the js, but also did not try to duplicate the previous "descriptions" functionality. The user can just go to the Stack Exchange site if they are interested.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better approach. We inherited the rss from Askbot, but the direct API access is much better to take advantage of now that we've switched over.

I don't have a checkout handy to validate this, but since it's already completely broken, I'll put this in and we can iterate from there.

@tfoote tfoote merged commit 756e5f8 into ros-infrastructure:ros2 Sep 9, 2024
1 check passed
@rkent rkent deleted the fix-questions branch September 9, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Q&A embeds to Stack Exchange Broken due to CORS
2 participants