Make header and footer responsive and fixed height #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoote
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of several PRs to implement the new combined package list/search page.
The intent of this PR is two-fold. First, it reduces the overall size of the header, while also emphasizing more the core functionality of rosindex (which is the package, repo, and dependency lists). (See #415 for some comments on this.) Second, it makes the header and footer fixed-height responsively. This is needed for the upcoming Tabulator-based package search & list page, because we only want scroll bars on the table, not on both the viewport and table which is confusing.
This will change the look of rosindex significantly.
One major change is that the link to search in the header is removed. That link still appears on the home page (and the home page can be accessed from clicking on "Ros index" in the header.) In the short run this is probably not optimal, but there is a bit of chicken and egg problem in getting the new package search page installed. In the future search will be accessed directly from the "Package List" and "System Dependencies" pages (and possibly also in the "Repository List" page), and it will not make sense to have a single "search" link. But in the interim, until we have a combined search/list feature for the repositories, the existing combined search needs to be exposed, and the home page is where that is done.