Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tabulator for repo list and search #485

Draft
wants to merge 1 commit into
base: ros2
Choose a base branch
from

Conversation

rkent
Copy link

@rkent rkent commented Feb 21, 2025

Resolves #478

This is a demo of a combined repo and package search/list page. I'll set it as a DRAFT since I'd like to look it over before we move forward. This is intended s a concrete discussion starter for an option for #478.

This has all of the information in the current repo list (and more, also is searchable) except for the list of repo variants. That could be added pretty easily if desired, though horizontal space is a bit of an issue.

The repo header is vertically aligned with the package list headers, so you can click on that header and sort by date or by repo name.

The date is included before the repo name because the repo name field is of variable length, and it is better to have the variable length field be last.

The default sort here is by repo name, unlike the original which sorts by date. It would be easy to sort by date by default if desired.

Personally I like this, for the following reasons:

  • It has the same fields and general format of the package list, so if you learn how to search in one, it is obvious how to search the other. The package expansion also shows the relevant package fields.
  • Using common code is easier and more maintainable than trying to do a separate js implementation of the repos. Already many lessons I have learned from doing the package list have not been transferred to the system dependencies list.

Example of repo list:

image

@tfoote
Copy link
Member

tfoote commented Feb 21, 2025

I'm ok with the multiple row layout with the richer data. However, the most important data about the repository is what packages are in it. And having that collapsed makes browsing the repositories in the list basically just the string name of the repositories. And clicking to expand is very tedious /slow if you want to browse through the repositories and what's inside. So we should at least have them expanded by default, or possibly I might suggest that we not enable collapsing the package rows at all. Collapsing it is valuable to enable showing more on the page at once, but especially with the fast scrolling and quick seach Tabulator is enabling the compactness is no longer as valuable. And we're not optimizing for comparing repositories so that we need them to be rendered close to each other and you can collapse the ones in between.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabularize the Repositories list
2 participants