Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new grasp frame #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nlyubova
Copy link
Member

@nlyubova nlyubova commented Oct 2, 2017

@mikaelarguedas , what do you finally think about adding a grasping frame? it is actually very helpful for grasping objects with MoveIt.

@nlyubova
Copy link
Member Author

@mikaelarguedas Mikael, would you agree to add it to a new "grasp_frame" branch?

@mikaelarguedas
Copy link
Member

I remember we had the discussion before. I think the part that has still not be resolved is that introducing this new "virtual" link and joint makes us diverge from the internal model used by naoqi. Is the need to have an additional link for grasping ? or that the current gripper frame is not where it should be?

  • If the first one and it makes things easier for application development I'm fine with updating it.
  • If the latter: could we just change the current definition of L/RHand to have the gripper frame in the right place?

As in previous discussions, for whichever solution we chose, we should add this in the generators rather than in the generated files would be more future-proof and avoid unexpected breakage in the future.

I don't think we need to declare transmissions for joints that are actually not moving at all, so the new transmission tags should be removed IMO.

@nlyubova
Copy link
Member Author

@mikaelarguedas thanks for your answer! I agree for any of these two solutions. maybe it is better to update the current L/RHand if nobody use it.

Could you please update your package generating URDF if I provide new values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants