Docs for #3885 and #3879 #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMacenski
requested changes
Oct 25, 2023
| ============== ============================= | ||
|
|
||
| Description: | ||
| Internally the polygon is sampled for collision detection. sampling_distance is the distance between sampled points of the polygon. Applicable for ``polygon`` type. |
There was a problem hiding this comment.
Suggested change
| Internally the polygon is sampled for collision detection. sampling_distance is the distance between sampled points of the polygon. Applicable for ``polygon`` type. | |
| Internally the polygon is sampled for collision detection. sampling_distance is the distance between sampled points of the polygon. Applicable for ``polygon`` source type. |
| ============== ============================= | ||
|
|
||
| Description: | ||
| Internally the polygon is sampled for collision detection. sampling_distance is the distance between sampled points of the polygon. Applicable for ``polygon`` type. |
There was a problem hiding this comment.
Suggested change
| Internally the polygon is sampled for collision detection. sampling_distance is the distance between sampled points of the polygon. Applicable for ``polygon`` type. | |
| Internally the polygon is sampled for collision detection. sampling_distance is the distance between sampled points of the polygon. Applicable for ``polygon`` source type. |
| if the transformation from the robot base frame to the global frame does not become available during this timeout. | ||
|
|
||
| Publishing of collision points in collision monitor/detector for debugging purposes |
There was a problem hiding this comment.
Missing adding the polygon source type
| @@ -229,7 +229,7 @@ Observation sources parameters | |||
| ============== ============================= | |||
|
|
|||
| Description: | |||
| Type of polygon shape. Could be ``scan``, ``pointcloud`` or ``range``. | |||
| Type of polygon shape. Could be ``scan``, ``pointcloud``, ``range`` or ``polygon``. | |||
There was a problem hiding this comment.
Explain what polygon names / is. Scan/PC2/Range are pretty clear from context but this deserves a note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.