Add note on multirobot refactor to migration guide #609
Conversation
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
|
One more thing and this should be done https://docs.nav2.org/tuning/index.html --> remove the |
Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
force-pushed
the
luca/multirobot_migration
branch
from
315efce
to
662efa0
Compare
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
|
I fixed some formatting for you, LGTM |
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
|
It shows that I only wrote markdown in my life 😅, noticed that the highlighting of snippets wasn't working because it's supposed to be double backtick so fixed that in 3cc1e2e |
Signed-off-by: Luca Della Vedova <[email protected]>
| @@ -29,6 +29,14 @@ This costmap layer implements a plugin that processes sonar, IR, or other 1-D se | |||
| Description | |||
| Range topics to subscribe to. | |||
|
|
|||
| Relative topics will be relative to the node's parent namespace. | |||
There was a problem hiding this comment.
Missed the entry for map_topic now 😉
Sorry to be a stickler about docs, I know its frustrating :(
There was a problem hiding this comment.
Apologies not sure I follow, I thought map_topic is only a parameter in static_layer? Why is this comment on range_sensor_layer?
lucadv@noble:~/ionic_ws/src/nav2/navigation2/nav2_costmap_2d/plugins$ grep -r . -e map_topic
./static_layer.cpp: map_topic_.c_str(),
./static_layer.cpp: map_topic_, map_qos,
./static_layer.cpp: map_topic_ + "_updates",
./static_layer.cpp: declareParameter("map_topic", rclcpp::ParameterValue("map"));
./static_layer.cpp: node->get_parameter(name_ + "." + "map_topic", map_topic_);
./static_layer.cpp: map_topic_ = joinWithParentNamespace(map_topic_);
./static_layer.cpp: param_name == name_ + "." + "map_topic" ||
There was a problem hiding this comment.
I mean that i wanted you to add this block wrt clarification on the relative topic namespaces into the static layer's configuration guide for the map_topic now that it has the same behavior profile as topic for range / obstacle / voxel layers
|
Otherwise, I can merge |
Add migration for PR ros-navigation/navigation2#4715