-
Notifications
You must be signed in to change notification settings - Fork 159
add devcontainer support #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: ARK3r <[email protected]>
42c0f1e
to
8944083
Compare
Checkout |
Am I missing something here?
ran into this when running the following in the container:
|
Did you source the workspace? |
Signed-off-by: ARK3r <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know when you want me to take a look. I'm going to compare this a bit with the one we have in Nav2 itself, so you may want to do that and see if there's anything you want to have here as well. Personally I don't use these so broadly speaking if they look like they offer similar/same things and you tell me it works, that's good enough for me
Signed-off-by: ARK3r <[email protected]>
This works now and is using the nav2 images so as to not need the user to build the nav2 packages from source. However, I think I'll actually change it back to a draft PR, as you said, until the other example is done in case I need to make any changes to this. |
|
||
ENV SHELL=/bin/bash | ||
|
||
CMD ["/bin/bash"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just set this in the nav2_docker files instead so that they're ready to go?
Heavily inspired by https://docs.ros.org/en/rolling/How-To-Guides/Setup-ROS-2-with-VSCode-and-Docker-Container.html