Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE, this is just for reference, the
ros2
branch should remain separate for now.Hi guys, I went ahead and ported
map_msgs
and put it on thisros2
branch because we need it in the map display for rviz in ROS 2. I hope you guys don't mind that I put it on a branch rather than a fork.This does a few things:
map_msgs
std_msgs/Header
instead ofHeader
(required in ROS 2)move_base_msgs
AMENT_IGNORE
file (likeCATKIN_IGNORE
) for now since actions are still being portedIf you guys could close this pull request as an indication that this is all ok, that would be great. At that point I'd open a new issue to track that
move_base_msgs
needs porting when actions are done in ROS 2.Also, this repository may be able to have one branch for both ROS 1 and ROS 2 in the future, but that depends on some on going work to smooth migration. So I'll have to come back and touch things again when that's possible.
I also built this on top of #3 in the hope that gets merged at some point.
Please let me know if you guys have any issues with this or questions for me.
Thanks!