Use shell=False in when launching gazebo #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya <[email protected]>
jacobperron
approved these changes
May 10, 2022
|
I wonder if #1371 has caused the test to become flaky 🤔 |
|
@ros-pull-request-builder retest this please |
|
@jacobperron should I revert this until #1414 is resolved ? Also for |
|
@adityapande-1995 Since we haven't released this change into Foxy or Galactic yet, give me a few more days to follow-up on #1414 (sorry, it fell off my radar). If I'm still stuck on it by next week, we should probably revert this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1376
Fixes gazebo shutdown errors when using nested launch files.
Signed-off-by: Aditya [email protected]