Skip to content

Commit

Permalink
Removed action tutorials interfaces dependency
Browse files Browse the repository at this point in the history
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
  • Loading branch information
ahcorde committed Aug 30, 2024
1 parent b5038a0 commit 7308170
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion joy_teleop/config/joy_teleop_example.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ joy_teleop:

fibonacci:
type: action
interface_type: action_tutorials_interfaces/action/Fibonacci
interface_type: example_interfaces/action/Fibonacci
action_name: fibonacci
action_goal:
order: 5
Expand Down
1 change: 0 additions & 1 deletion joy_teleop/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
<exec_depend>trajectory_msgs</exec_depend>
<exec_depend>rosidl_runtime_py</exec_depend>

<test_depend>action_tutorials_interfaces</test_depend>
<test_depend>ament_copyright</test_depend>
<test_depend>ament_flake8</test_depend>
<test_depend>ament_pep257</test_depend>
Expand Down
8 changes: 4 additions & 4 deletions joy_teleop/test/test_action_fibonacci.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.

import action_tutorials_interfaces.action
import example_interfaces.action
from joy_teleop_testing_common import generate_joy_test_description, TestJoyTeleop
import pytest
import rclpy
Expand All @@ -42,7 +42,7 @@
def generate_test_description():
parameters = {}
parameters['fibonacci.type'] = 'action'
parameters['fibonacci.interface_type'] = 'action_tutorials_interfaces/action/Fibonacci'
parameters['fibonacci.interface_type'] = 'example_interfaces/action/Fibonacci'
parameters['fibonacci.action_name'] = '/fibonacci'
parameters['fibonacci.buttons'] = [2]
parameters['fibonacci.action_goal'] = {'order': 5}
Expand All @@ -69,14 +69,14 @@ def fibonacci_callback(goal_handle):
sequence.append(sequence[i] + sequence[i-1])

goal_handle.succeed()
result = action_tutorials_interfaces.action.Fibonacci.Result()
result = example_interfaces.action.Fibonacci.Result()
result.sequence = sequence
future.set_result(True)
return result

action_server = rclpy.action.ActionServer(
self.node,
action_tutorials_interfaces.action.Fibonacci,
example_interfaces.action.Fibonacci,
'fibonacci',
fibonacci_callback)

Expand Down
2 changes: 1 addition & 1 deletion joy_teleop/test/test_parameter_failures.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def test_service_invalid_message_fields(self):
def test_action_invalid_message_fields(self):
parameters = {}
parameters['fibonacci.type'] = 'action'
parameters['fibonacci.interface_type'] = 'action_tutorials_interfaces/action/Fibonacci'
parameters['fibonacci.interface_type'] = 'example_interfaces/action/Fibonacci'
parameters['fibonacci.action_name'] = '/fibonacci'
parameters['fibonacci.buttons'] = [2]
parameters['fibonacci.action_goal'] = {'foo': 5}
Expand Down

0 comments on commit 7308170

Please sign in to comment.