-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update colcon-* versions #42
Update colcon-* versions #42
Conversation
Signed-off-by: Kenji Miyake <[email protected]>
This looks good to me, but since there's no tagging/versioning for these images, it means that, if someone is using an older version of |
Signed-off-by: Kenji Miyake <[email protected]>
9808368
to
0659b31
Compare
@christophebedard I'm sorry, I forgot to change as you suggested. Now it's done. |
Thanks! Were you able to test it with
I would let @emersonknapp answer this. |
Not yet. |
You can probably modify the workflow config on your fork and get it to build the image on a branch other than |
@christophebedard Okay, I'll try it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per discussion on tracking issue - adding my review to clear it from my queue for now
Closing as stale for now - please open new PR if change will be worked on in the future |
Resolves #41