Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum width on right pane to avoid overlap #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kukanani
Copy link

Before this fix, the minimum width of the right pane was 0, which would result in the following at narrow widths:

before_overlap_fix

After this fix, the panel has a minimum width to prevent this behavior (this is the narrowest the panel resizes):

after_overlap_fix

@cottsay
Copy link
Member

cottsay commented Oct 12, 2017

This solution mitigates the problem in most common circumstances, but it doesn't really solve the problem. For example, nested parameter groups like tabs still suffer.

I found that the most expedient solution which would work for all of the parameter layouts is to remove the minimum size from the parameter name QLabel, which was set to 100px. When you make the window really small, the value editing widget still jumps over to where the label used to be shown, but the label disappears correctly instead of overlapping.

I find that this might be a better solution than enforcing minimum sizes on the layout which might be a problem for small displays like netbooks used to run robots.

Please take a look at #14 and let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants