Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscardAnalyzer doesn't work together with GenericAnalyzer #128

Open
MCFurry opened this issue Oct 25, 2019 · 4 comments
Open

DiscardAnalyzer doesn't work together with GenericAnalyzer #128

MCFurry opened this issue Oct 25, 2019 · 4 comments

Comments

@MCFurry
Copy link

MCFurry commented Oct 25, 2019

Please see the following example of my diagnostic_aggregator configuration:

ecu:
  type: diagnostic_aggregator/GenericAnalyzer
  path: 'ECU'
  startswith: 'ecu_reporter'
  remove_prefix: 'ecu_reporter_node: '
ecu_discard1:
  type: diagnostic_aggregator/DiscardAnalyzer
  path: none
  contains: 'Error_676'
ecu_discard2:
  type: diagnostic_aggregator/DiscardAnalyzer
  path: none
  contains: 'Error_1235'

The problem seems that no diagnostic messages coming from this node are discarded anymore now that the GenericAnalyzer matches them as well and groups them.
There doesn't seem to be any specific ordering in processing GenericAnalyzer vs DiscardAnalyzer?
Am I miss-using the analyzers or is there a bug here?

In the end I would like to put all diagnostic messages from ecu_reporter_node in the same path such that rqt_robot_monitor groups them, unless they are discarded of course.

@amilcarlucas
Copy link

This is probably fixed now. Can you update and re-test?

@MCFurry
Copy link
Author

MCFurry commented Sep 21, 2020

Thx, I'll try to re-evaluate asap!
Is this fix in the apt-released version or do I need to test the latest source?

@amilcarlucas
Copy link

apt-released should have it

@yangyy11
Copy link

apt-released should have it

Please see the following example of my diagnostic_aggregator configuration:

ecu:
  type: diagnostic_aggregator/GenericAnalyzer
  path: 'ECU'
  startswith: 'ecu_reporter'
  remove_prefix: 'ecu_reporter_node: '
ecu_discard1:
  type: diagnostic_aggregator/DiscardAnalyzer
  path: none
  contains: 'Error_676'
ecu_discard2:
  type: diagnostic_aggregator/DiscardAnalyzer
  path: none
  contains: 'Error_1235'

The problem seems that no diagnostic messages coming from this node are discarded anymore now that the GenericAnalyzer matches them as well and groups them.
There doesn't seem to be any specific ordering in processing GenericAnalyzer vs DiscardAnalyzer?
Am I miss-using the analyzers or is there a bug here?

In the end I would like to put all diagnostic messages from ecu_reporter_node in the same path such that rqt_robot_monitor groups them, unless they are discarded of course.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants