Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add APIs to pause/resume/start updaters #226

Open
homalozoa opened this issue Mar 28, 2022 · 0 comments
Open

[Feature request] Add APIs to pause/resume/start updaters #226

homalozoa opened this issue Mar 28, 2022 · 0 comments
Labels
enhancement This tackles a new feature of the code (and not a bug)

Comments

@homalozoa
Copy link

As I observed, there isn't any APIs to pause/resume/start diagnostic updaters. Especially when invoking diagnostic_updaters in LifecycleNodes, diagnostic updaters begins publishing topic to /diagnostics just after LifecycleNodes constructing. As description in Managed Nodes, publishers in Lifecyclenodes should be configured and activated before publishing topics.

In my opinion, there are two ways:

  1. We need to add some APIs to pause/resume/start updaters for special usage. Then we will face with choices: Will updater run timer by default? or updater only run timer after called "start" function?
  2. We add a new header file, eg. diagnostic_updater_lifecycle.hpp. And create a class derived from DiagnosticTaskVector that class Updater derived. Then implement all LifecycleNodes' APIs in it.
@ct2034 ct2034 added the enhancement This tackles a new feature of the code (and not a bug) label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This tackles a new feature of the code (and not a bug)
Projects
None yet
Development

No branches or pull requests

2 participants