Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add possibility to load further aggregator configurations after node was started #313

Open
BEG-Katzenberger opened this issue Aug 2, 2023 · 1 comment
Labels
enhancement This tackles a new feature of the code (and not a bug) PR welcome 💞 This issue has no PR that tries to implement it. Please create one! ros2 PR tackling a ROS2 branch

Comments

@BEG-Katzenberger
Copy link

Currently the aggregator node only reads it's configuration once right after start and it is not possible to update this config later.

Our use-case: we have two independent systems with separated aggregator configs and the aggregator node is started by the first running system. If the second system is started the aggregator node on the first system should now take over the aggregator configuration from the second system.

Unfortunately running an other aggregator node on the second system leads to a toggling view in the rqt_robot_monitor GUI.

@ct2034 ct2034 added the enhancement This tackles a new feature of the code (and not a bug) label Sep 26, 2023
@ct2034
Copy link
Collaborator

ct2034 commented Sep 26, 2023

Thanks @BEG-Katzenberger for the feature request. PRs are welcome. ;-)

Do you think this could also be solved by the node lifecycle?
I am currently trying to think of different ways to make your use case possible, but I guess there are multiple options:

  • Kill original node and make new one with new config
  • Make config expandable at runtime
  • Decouple separate aggregators completely such that they are separate processes, anyway.

What do you think?

@ct2034 ct2034 added the ros2 PR tackling a ROS2 branch label Nov 20, 2023
@ct2034 ct2034 added the PR welcome 💞 This issue has no PR that tries to implement it. Please create one! label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This tackles a new feature of the code (and not a bug) PR welcome 💞 This issue has no PR that tries to implement it. Please create one! ros2 PR tackling a ROS2 branch
Projects
None yet
Development

No branches or pull requests

2 participants