Skip to content

fix: add Cargo.lock to version control #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

esteve
Copy link
Collaborator

@esteve esteve commented May 28, 2025

This should fix the issues in our CI with backtrace requiring Rust 1.82

@esteve esteve requested review from maspe36 and jhdcs May 28, 2025 21:40
Copy link
Collaborator

@maspe36 maspe36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this only an issue with the windows actions? I don't fully understand that component, but either way this is a worthwhile change IMO.

@esteve
Copy link
Collaborator Author

esteve commented Jun 1, 2025

@maspe36 I don't understand why that's an issue on Windows, but since we agreed to commit Cargo.lock anyway, I thought this might help. Thanks for the review

@esteve esteve merged commit 334f469 into ros2-rust:main Jun 1, 2025
4 checks passed
@esteve esteve deleted the add-cargo-lock branch June 1, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants