Add RISC-V 64 Support #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use gnu_hash in preference to the standard hash table, as it's more efficient, and fall back to the tranditional table if we can't find it. This should fix problems on systems that do not provide the traditional ELF hash table for symbols.
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/installing-ros2-humble-on-risc-v-ubuntu/35988/4 |
|
I successfully built ROS 2 for RISC-V 64 with this PR. You can reproduce it following this post: https://discourse.ros.org/t/installing-ros2-humble-on-risc-v-ubuntu/35988 |
I am not familiar with ROS2, much thanks for your work to verify this PR works! |
mjcarroll
added a commit
to ros2/mimick_vendor
that referenced
this pull request
Feb 26, 2024
Signed-off-by: Michael Carroll <[email protected]>
|
Testing via ros2/mimick_vendor#36
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for RISC-V 64 architecture and documented this. Also adds tests for functions with float/double arguments. This has been tested on Debian sid riscv64.
Commit "Implement gnu_hash symbol lookup" (93b10bf in the upstream) is necessary to make Mimick function properly on RISC-V 64, so is cherry-picked.
Close #30