-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ci jobs for Iron irwini #796
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I approve of this, I think we should hold off on merging this until we've had the final sync out for at least a month. That way, if we need to do another patch release for some reason, everything still exists. Thus I'm going to mark this as a "Draft" for right now, though I am going to manually disable the iron_coverage job on https://ci.ros2.org to save us a bit of compute time.
Signed-off-by: Yadunund <[email protected]>
a98c8fc
to
9bc7582
Compare
@cottsay / @nuclearsandwich this PR should be ready to merge after a quick review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to my eyes.
grep is reporting a few more occurrences in linux_docker_resources
, do we need to delete these too?
ci on yadu/iron-eol underwent 10s❯ grep -R 'iron ' *
linux_docker_resources/Dockerfile-RHEL: $(if test \( ${ROS_DISTRO} = humble -o ${ROS_DISTRO} = iron \); then echo tinyxml-devel; fi) \
linux_docker_resources/Dockerfile: ; elif test \( ${ROS_DISTRO} = iron \); then \
linux_docker_resources/Dockerfile:RUN if test \( ${ROS_DISTRO} = humble -o ${ROS_DISTRO} = iron \); then apt-get update && apt-get install --no-install-recommends -y libtinyxml-dev; f
Signed-off-by: Yadunund <[email protected]>
Made changes similar to