Restore daily invalidation of Windows Dockerfile. #807
Conversation
This was removed in #802 when removing the chef configuration but we do this on Linux as well. It makes sense to do this before configuring the pixi workspace if not also doing before pixi installation. In the chef configuration, due to the amount of time spent in installation we did one chef provision before invalidation and then one after it in the hope that unchanged things would stay unchanged and the catchup run would not take as much time each day. On linux we invalidate after initial configuration but before dependency installation so we could move this up in the Windows container if we want. Also I renamed the sigil string from `todays_date` to `today_str` so that the sigil we use on Linux and Windows match.
|
Test CI Windows |
This is only half true. On Ubuntu, we do indeed do the invalidation before we install most of the dependencies. On RHEL, we do the invalidation after the installation of basically everything; the only thing after this is the setup of the user, colcon, and the entry point. I think we should probably make all 3 consistent, and I would be for doing it before installing dependencies (so we get the latest). What do you think? |
Eh, this is misleading. The invalidation is immediately followed by an update to all packages. We should never be more than 24hrs out-of-date in our RHEL containers. |
Yeah, I was just looking over the code again and noticing that. In that case, then I'm fine with this as-is, though it might be nice for Docker cache purposes to make Ubuntu follow the same pattern as RHEL. |
|
I see a change to the job config a few minutes ago, so it seems that it was deployed. Thanks! |
This was removed in #802 when removing the chef configuration but we do
this on Linux as well.
It makes sense to do this before configuring the pixi workspace if not
also doing before pixi installation.
In the chef configuration, due to the amount of time spent in
installation we did one chef provision before invalidation and then one
after it in the hope that unchanged things would stay unchanged and the
catchup run would not take as much time each day.
On linux we invalidate after initial configuration but before
dependency installation so we could move this up in the Windows
container if we want.
Also I renamed the sigil string from
todays_datetotoday_strsothat the sigil we use on Linux and Windows match.