Clearer Display of OpenCV window in image_tools/showimage ROS2 node #668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This For?
The purpose of this pull request is to introduce a small but helpful change to the
showimage
ROS 2 node under theimage_tools
package.This change includes a few new lines under the file
image_tools/src/showimage.cpp
that defines the starting position for an OpenCV window display atx=0, y=0
desktop pixel position; the top-left corner of a user's desktop.Why?
I have been using
image_tools
for a quite a while now. Here are the following reasons why I believe this small change could help improve the user experience for any developers who used the ROS 2 node in their own project:Other Remarks
In order to better fit the OpenCV window into a user's desktop automatically, I am considering implementing a resize feature within
showimage
ofimage_tools
ROS 2 package (which should not take long actually).However, I fear it may introduce additional dependencies which may complicate testing down the line. To the maintainers, do let me know your thoughts on this. In the meantime, will do my own testing offline and update if it is just a false fear.
Welcoming any constructive feedbacks on this matter and what I can do to contribute to this amazing community. To the maintainers, thank you for the work you have done so far in this repository and will continue to support in whatever way I can, given personal bandwidth.☺️